You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
LGTM on the accessibility logic, but could you please confirm where speakLabel is actually called in the menu loop and check if the export keyword is compatible with the current module system
Thanks for the review!
Currently, speakLabel() is defined as a private helper within this module and is intended to be invoked from the pie menu selection handler, not attached to the render loop, but meant to be called inside the selection logic to ensure it only announces confirmed selections and avoids repeated triggers during hover or redraw cycles.
export keyword compatibility
If piemenus.js is currently loaded via a classic script tag or follows a non-ESM module pattern, then export would indeed not be compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds accessible audio feedback to pie menu selections.
aria-liveregion to ensure screen readers also announce selections.This improves accessibility for visually impaired users while maintaining backward compatibility and user control over the feature.